Add COLNAMES option to give names to the columns #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x2bool
requested changes
Jan 7, 2023
| @@ -49,6 +51,16 @@ fn parse_range_option(input: &str) -> IResult<&str, UsingOption> { | |||
| |t: (&str, &str)| UsingOption::Range(t.1.to_string()))(input) | |||
| } | |||
|
|
|||
| fn parse_colnames_option(input: &str) -> IResult<&str, UsingOption> { | |||
There was a problem hiding this comment.
Would you mind adding a test for this option? Very basic and simple. This would also document what is considered as allowed input for this option.
Also adding example to README.md would be nice, but I could do this myself.
There was a problem hiding this comment.
I added some tests. I tried to add to the readme too, but I wasn't sure how to do explain it clearly.
The COLNAMES option should contain the row number giving the name to the columns. This name will be used in place of the lettered column name used by excel in the SQL Table.
|
While adding the tests, I fixed |
|
Good feature! Thank you for your work 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The COLNAMES option should contain the row number giving the name to the columns. This name will be used in place of the lettered column name used by excel in the SQL Table.